SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.7.3
Threshold is medium
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 131 |
109 |
0 |
1 |
org.csveed.api.CsvClientImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.api.CsvClientImpl.getRowWriter() may expose internal representation by returning CsvClientImpl.rowWriter |
MALICIOUS_CODE |
EI_EXPOSE_REP |
400 |
Medium |
| Constructor new org.csveed.api.CsvClientImpl(Writer) makes call to non-final method |
CORRECTNESS |
PCOA_PARTIALLY_CONSTRUCTED_OBJECT_ACCESS |
69 |
Medium |
| Constructor new org.csveed.api.CsvClientImpl(Writer, BeanInstructions) makes call to non-final method |
CORRECTNESS |
PCOA_PARTIALLY_CONSTRUCTED_OBJECT_ACCESS |
95 |
Medium |
org.csveed.api.CsvClientTest
| Bug |
Category |
Details |
Line |
Priority |
| Method org.csveed.api.CsvClientTest.readLines(String) excessively uses methods of another class |
STYLE |
CE_CLASS_ENVY |
278-297 |
Medium |
| Method org.csveed.api.CsvClientTest.headerNotWrittenForOtherwiseEmptyCsv() uses a Side Effect Constructor |
STYLE |
SEC_SIDE_EFFECT_CONSTRUCTOR |
363 |
Medium |
org.csveed.bean.AbstractMapper
| Bug |
Category |
Details |
Line |
Priority |
| Unconstrained method org.csveed.bean.AbstractMapper.setBeanProperty(Row, int, BeanWrapper, Column, String, BeanProperty) converts checked exception to unchecked |
STYLE |
EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS |
187 |
High |
| Method org.csveed.bean.AbstractMapper.convert(Object, Row, int, DynamicColumn) makes literal string comparisons passing the literal as an argument |
STYLE |
LSC_LITERAL_STRING_COMPARISON |
126 |
High |
org.csveed.bean.BeanInstructionsImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.bean.BeanInstructionsImpl.getProperties() may expose internal representation by returning BeanInstructionsImpl.properties |
MALICIOUS_CODE |
EI_EXPOSE_REP |
251 |
Medium |
| org.csveed.bean.BeanInstructionsImpl.getStartIndexDynamicColumns() may expose internal representation by returning BeanInstructionsImpl.startIndexDynamicColumns |
MALICIOUS_CODE |
EI_EXPOSE_REP |
256 |
Medium |
| To make log readable, log format ({}) should contain non-sign character. |
BAD_PRACTICE |
SLF4J_SIGN_ONLY_FORMAT |
71 |
Medium |
org.csveed.bean.BeanParser
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.bean.BeanParser.getBeanInstructions(Class) may expose internal representation by returning BeanParser.beanInstructions |
MALICIOUS_CODE |
EI_EXPOSE_REP |
61 |
Medium |
| Unconstrained method org.csveed.bean.BeanParser.parseCsvConverter(String, CsvConverter) converts checked exception to unchecked |
STYLE |
EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS |
160 |
High |
| Method org.csveed.bean.BeanParser.checkForAnnotations(BeanProperty) uses instanceof on multiple types to arbitrate logic |
STYLE |
ITC_INHERITANCE_TYPE_CHECKING |
77 |
Medium |
org.csveed.bean.BeanProperties
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.bean.BeanProperties.getHeaderNameProperty() may expose internal representation by returning BeanProperties.headerNameProperty |
MALICIOUS_CODE |
EI_EXPOSE_REP |
273 |
Medium |
| org.csveed.bean.BeanProperties.getHeaderValueProperty() may expose internal representation by returning BeanProperties.headerValueProperty |
MALICIOUS_CODE |
EI_EXPOSE_REP |
264 |
Medium |
| Unconstrained method org.csveed.bean.BeanProperties.parseBean(Class) converts checked exception to unchecked |
STYLE |
EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS |
85 |
High |
| Method org.csveed.bean.BeanProperties.addProperty(PropertyDescriptor, Field) appears to call the same method on the same object redundantly |
PERFORMANCE |
PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS |
120 |
Medium |
org.csveed.bean.BeanProperty
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.bean.BeanProperty.getField() may expose internal representation by returning BeanProperty.field |
MALICIOUS_CODE |
EI_EXPOSE_REP |
158 |
Medium |
| org.csveed.bean.BeanProperty.getPropertyDescriptor() may expose internal representation by returning BeanProperty.propertyDescriptor |
MALICIOUS_CODE |
EI_EXPOSE_REP |
63 |
Medium |
| org.csveed.bean.BeanProperty.setField(Field) may expose internal representation by storing an externally mutable object into BeanProperty.field |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
168 |
Medium |
| org.csveed.bean.BeanProperty.setPropertyDescriptor(PropertyDescriptor) may expose internal representation by storing an externally mutable object into BeanProperty.propertyDescriptor |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
73 |
Medium |
| Method org.csveed.bean.BeanProperty.getNumberClass() appears to call the same method on the same object redundantly |
PERFORMANCE |
PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS |
52 |
Medium |
org.csveed.bean.BeanPropertyTest
| Bug |
Category |
Details |
Line |
Priority |
| Method org.csveed.bean.BeanPropertyTest.construct() excessively uses methods of another class |
STYLE |
CE_CLASS_ENVY |
40-53 |
Medium |
org.csveed.bean.BeanReaderImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.bean.BeanReaderImpl.getMapper() may expose internal representation by returning BeanReaderImpl.mapper |
MALICIOUS_CODE |
EI_EXPOSE_REP |
88 |
Medium |
| Unconstrained method org.csveed.bean.BeanReaderImpl.createMappingStrategy() converts checked exception to unchecked |
STYLE |
EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS |
198 |
High |
| Unconstrained method org.csveed.bean.BeanReaderImpl.instantiateBean() converts checked exception to unchecked |
STYLE |
EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS |
173 |
High |
| To make log readable, log format () should contain non-sign character. |
BAD_PRACTICE |
SLF4J_SIGN_ONLY_FORMAT |
197 |
Medium |
org.csveed.bean.BeanWriterImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.bean.BeanWriterImpl.getRowWriter() may expose internal representation by returning BeanWriterImpl.rowWriter |
MALICIOUS_CODE |
EI_EXPOSE_REP |
119 |
Medium |
| To make log readable, log format ({}) should contain non-sign character. |
BAD_PRACTICE |
SLF4J_SIGN_ONLY_FORMAT |
96 |
Medium |
| To make log readable, log format () should contain non-sign character. |
BAD_PRACTICE |
SLF4J_SIGN_ONLY_FORMAT |
97 |
Medium |
org.csveed.bean.ColumnNameMapper
| Bug |
Category |
Details |
Line |
Priority |
| To make log readable, log format () should contain non-sign character. |
BAD_PRACTICE |
SLF4J_SIGN_ONLY_FORMAT |
49 |
Medium |
org.csveed.bean.conversion.Bean
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.bean.conversion.Bean.getBytes() may expose internal representation by returning Bean.bytes |
MALICIOUS_CODE |
EI_EXPOSE_REP |
179 |
Medium |
| org.csveed.bean.conversion.Bean.getChars() may expose internal representation by returning Bean.chars |
MALICIOUS_CODE |
EI_EXPOSE_REP |
198 |
Medium |
| org.csveed.bean.conversion.Bean.getTimeZone() may expose internal representation by returning Bean.timeZone |
MALICIOUS_CODE |
EI_EXPOSE_REP |
160 |
Medium |
| org.csveed.bean.conversion.Bean.setBytes(byte[]) may expose internal representation by storing an externally mutable object into Bean.bytes |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
189 |
Medium |
| org.csveed.bean.conversion.Bean.setChars(char[]) may expose internal representation by storing an externally mutable object into Bean.chars |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
208 |
Medium |
| org.csveed.bean.conversion.Bean.setTimeZone(TimeZone) may expose internal representation by storing an externally mutable object into Bean.timeZone |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
170 |
Medium |
org.csveed.bean.conversion.BeanWrapper
| Bug |
Category |
Details |
Line |
Priority |
| new org.csveed.bean.conversion.BeanWrapper(DefaultConverters, Object) may expose internal representation by storing an externally mutable object into BeanWrapper.defaultConverters |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
37 |
Medium |
| Method org.csveed.bean.conversion.BeanWrapper.setProperty(BeanProperty, String) makes literal string comparisons passing the literal as an argument |
STYLE |
LSC_LITERAL_STRING_COMPARISON |
84 |
High |
org.csveed.bean.conversion.BeanWrapperTest
org.csveed.bean.conversion.Coordinate
| Bug |
Category |
Details |
Line |
Priority |
| Method org.csveed.bean.conversion.Coordinate.fromString(String) converts String to boxed primitive using excessive boxing |
PERFORMANCE |
NAB_NEEDLESS_BOXING_VALUEOF |
70 |
Medium |
org.csveed.bean.conversion.CustomBooleanConverter
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.bean.conversion.CustomBooleanConverter.fromString(String) has Boolean return type and returns explicit null |
BAD_PRACTICE |
NP_BOOLEAN_RETURN_NULL |
96 |
Medium |
| Method org.csveed.bean.conversion.CustomBooleanConverter.fromString(String) returns null for Boolean type |
STYLE |
TBP_TRISTATE_BOOLEAN_PATTERN |
96 |
Medium |
org.csveed.bean.conversion.CustomNumberConverter
| Bug |
Category |
Details |
Line |
Priority |
| new org.csveed.bean.conversion.CustomNumberConverter(Class, NumberFormat, boolean) may expose internal representation by storing an externally mutable object into CustomNumberConverter.numberFormat |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
68 |
Medium |
org.csveed.bean.conversion.DateConverter
| Bug |
Category |
Details |
Line |
Priority |
| Unconstrained method org.csveed.bean.conversion.DateConverter.fromString(String) converts checked exception to unchecked |
STYLE |
EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS |
66 |
High |
| Null passed for non-null parameter of java.text.DateFormat.parse(String) in org.csveed.bean.conversion.DateConverter.fromString(String) |
CORRECTNESS |
NP_NULL_PARAM_DEREF |
64 |
Medium |
org.csveed.bean.conversion.DefaultConverters
org.csveed.bean.conversion.EasyAbstractConverterTest$1
| Bug |
Category |
Details |
Line |
Priority |
| Non derivable method org.csveed.bean.conversion.EasyAbstractConverterTest$1.fromString(String) declares throwing an exception that isn't thrown |
CORRECTNESS |
BED_BOGUS_EXCEPTION_DECLARATION |
33 |
Medium |
org.csveed.bean.conversion.NumberUtils
| Bug |
Category |
Details |
Line |
Priority |
| Method org.csveed.bean.conversion.NumberUtils.convertNumberToTargetClass(Number, Class) declares RuntimeException in throws clause |
STYLE |
DRE_DECLARED_RUNTIME_EXCEPTION |
52-99 |
Medium |
| Unconstrained method org.csveed.bean.conversion.NumberUtils.parseNumber(String, Class, NumberFormat) converts checked exception to unchecked |
STYLE |
EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS |
188 |
High |
| Method org.csveed.bean.conversion.NumberUtils.parseNumber(String, Class, NumberFormat) throws alternative exception from catch block without history |
CORRECTNESS |
LEST_LOST_EXCEPTION_STACK_TRACE |
188 |
Medium |
org.csveed.common.ColumnTest
| Bug |
Category |
Details |
Line |
Priority |
| Method org.csveed.common.ColumnTest.lambda$wrongIndex$0() uses a Side Effect Constructor |
STYLE |
SEC_SIDE_EFFECT_CONSTRUCTOR |
63 |
Medium |
org.csveed.report.CsvException
| Bug |
Category |
Details |
Line |
Priority |
| To make log readable, log format ({}) should contain non-sign character. |
BAD_PRACTICE |
SLF4J_SIGN_ONLY_FORMAT |
39 |
Medium |
org.csveed.report.RowReport
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.report.RowReport.createContentLine(List): 1st parameter 'parts' could be declared as java.lang.Iterable instead |
STYLE |
OCP_OVERLY_CONCRETE_PARAMETER |
117 |
Medium |
| org.csveed.report.RowReport.createFocusLine(List): 1st parameter 'parts' could be declared as java.lang.Iterable instead |
STYLE |
OCP_OVERLY_CONCRETE_PARAMETER |
133 |
Medium |
| This method org.csveed.report.RowReport.tokenize() parses a String that is a field |
STYLE |
STT_STRING_PARSING_A_FIELD |
81 |
Medium |
| This method org.csveed.report.RowReport.tokenize() parses a String that is a field |
STYLE |
STT_STRING_PARSING_A_FIELD |
84 |
Medium |
| This method org.csveed.report.RowReport.tokenize() parses a String that is a field |
STYLE |
STT_STRING_PARSING_A_FIELD |
87 |
Medium |
org.csveed.report.RowReportTest
org.csveed.row.LineWithInfoTest
org.csveed.row.RowInstructionsImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.row.RowInstructionsImpl.getSymbolMapping() may expose internal representation by returning RowInstructionsImpl.symbolMapping |
MALICIOUS_CODE |
EI_EXPOSE_REP |
59 |
Medium |
org.csveed.row.RowReaderImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.row.RowReaderImpl.getRowInstructions() may expose internal representation by returning RowReaderImpl.rowInstructions |
MALICIOUS_CODE |
EI_EXPOSE_REP |
199 |
Medium |
| new org.csveed.row.RowReaderImpl(Reader, RowInstructions) may expose internal representation by storing an externally mutable object into RowReaderImpl.rowInstructions |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
66 |
Medium |
| Unconstrained method org.csveed.row.RowReaderImpl.readBareLine() converts checked exception to unchecked |
STYLE |
EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS |
171 |
High |
| Unconstrained method org.csveed.row.RowReaderImpl.readBareLine() converts checked exception to unchecked |
STYLE |
EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS |
176 |
High |
| Method new org.csveed.row.RowReaderImpl(Reader, RowInstructions) defines parameters more abstractly than needed to function properly |
CORRECTNESS |
PDP_POORLY_DEFINED_PARAMETER |
66 |
Medium |
org.csveed.row.RowReaderTest
| Bug |
Category |
Details |
Line |
Priority |
| Method org.csveed.row.RowReaderTest.reportEscapingAndQuotes() appears to call the same method on the same object redundantly |
PERFORMANCE |
PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS |
282 |
Medium |
| Method org.csveed.row.RowReaderTest.reportSimple() appears to call the same method on the same object redundantly |
PERFORMANCE |
PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS |
265 |
Medium |
org.csveed.row.RowWriterImpl
| Bug |
Category |
Details |
Line |
Priority |
| new org.csveed.row.RowWriterImpl(Writer, RowInstructions) may expose internal representation by storing an externally mutable object into RowWriterImpl.writer |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
61 |
Medium |
| Unconstrained method org.csveed.row.RowWriterImpl.writeCells(Iterator) converts checked exception to unchecked |
STYLE |
EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS |
142 |
High |
| To make log readable, log format () should contain non-sign character. |
BAD_PRACTICE |
SLF4J_SIGN_ONLY_FORMAT |
141 |
Medium |
org.csveed.test.model.BeanVariousNotAnnotated
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.test.model.BeanVariousNotAnnotated.getDate() may expose internal representation by returning BeanVariousNotAnnotated.date |
MALICIOUS_CODE |
EI_EXPOSE_REP |
104 |
Medium |
| org.csveed.test.model.BeanVariousNotAnnotated.getSimple() may expose internal representation by returning BeanVariousNotAnnotated.simple |
MALICIOUS_CODE |
EI_EXPOSE_REP |
161 |
Medium |
| org.csveed.test.model.BeanVariousNotAnnotated.getYearMonth() may expose internal representation by returning BeanVariousNotAnnotated.yearMonth |
MALICIOUS_CODE |
EI_EXPOSE_REP |
123 |
Medium |
| org.csveed.test.model.BeanVariousNotAnnotated.setDate(Date) may expose internal representation by storing an externally mutable object into BeanVariousNotAnnotated.date |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
114 |
Medium |
| org.csveed.test.model.BeanVariousNotAnnotated.setSimple(BeanSimple) may expose internal representation by storing an externally mutable object into BeanVariousNotAnnotated.simple |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
171 |
Medium |
| org.csveed.test.model.BeanVariousNotAnnotated.setYearMonth(Date) may expose internal representation by storing an externally mutable object into BeanVariousNotAnnotated.yearMonth |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
133 |
Medium |
org.csveed.test.model.BeanWithConverter
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.test.model.BeanWithConverter.getBean() may expose internal representation by returning BeanWithConverter.bean |
MALICIOUS_CODE |
EI_EXPOSE_REP |
33 |
Medium |
| org.csveed.test.model.BeanWithConverter.setBean(BeanSimple) may expose internal representation by storing an externally mutable object into BeanWithConverter.bean |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
43 |
Medium |
org.csveed.test.model.BeanWithNonStandardObject
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.test.model.BeanWithNonStandardObject.getBean() may expose internal representation by returning BeanWithNonStandardObject.bean |
MALICIOUS_CODE |
EI_EXPOSE_REP |
30 |
Medium |
| org.csveed.test.model.BeanWithNonStandardObject.setBean(BeanSimple) may expose internal representation by storing an externally mutable object into BeanWithNonStandardObject.bean |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
40 |
Medium |
org.csveed.test.model.BeanWithVariousTypes
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.test.model.BeanWithVariousTypes.getDate() may expose internal representation by returning BeanWithVariousTypes.date |
MALICIOUS_CODE |
EI_EXPOSE_REP |
102 |
Medium |
| org.csveed.test.model.BeanWithVariousTypes.getYearMonth() may expose internal representation by returning BeanWithVariousTypes.yearMonth |
MALICIOUS_CODE |
EI_EXPOSE_REP |
121 |
Medium |
| org.csveed.test.model.BeanWithVariousTypes.setDate(Date) may expose internal representation by storing an externally mutable object into BeanWithVariousTypes.date |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
112 |
Medium |
| org.csveed.test.model.BeanWithVariousTypes.setYearMonth(Date) may expose internal representation by storing an externally mutable object into BeanWithVariousTypes.yearMonth |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
131 |
Medium |
org.csveed.test.model.BeanWithoutHeader
| Bug |
Category |
Details |
Line |
Priority |
| org.csveed.test.model.BeanWithoutHeader.getDate() may expose internal representation by returning BeanWithoutHeader.date |
MALICIOUS_CODE |
EI_EXPOSE_REP |
104 |
Medium |
| org.csveed.test.model.BeanWithoutHeader.getYearMonth() may expose internal representation by returning BeanWithoutHeader.yearMonth |
MALICIOUS_CODE |
EI_EXPOSE_REP |
123 |
Medium |
| org.csveed.test.model.BeanWithoutHeader.setDate(Date) may expose internal representation by storing an externally mutable object into BeanWithoutHeader.date |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
114 |
Medium |
| org.csveed.test.model.BeanWithoutHeader.setYearMonth(Date) may expose internal representation by storing an externally mutable object into BeanWithoutHeader.yearMonth |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
133 |
Medium |
org.csveed.token.ParseStateMachine
| Bug |
Category |
Details |
Line |
Priority |
| Method org.csveed.token.ParseStateMachine.determineState(int, EncounteredSymbol) is excessively complex, with a cyclomatic complexity of 57 |
STYLE |
CC_CYCLOMATIC_COMPLEXITY |
233 |
Medium |
| org.csveed.token.ParseStateMachine.getSymbolMapping() may expose internal representation by returning ParseStateMachine.symbolMapping |
MALICIOUS_CODE |
EI_EXPOSE_REP |
365 |
Medium |
| org.csveed.token.ParseStateMachine.setSymbolMapping(SymbolMapping) may expose internal representation by storing an externally mutable object into ParseStateMachine.symbolMapping |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
356 |
Medium |
| Method org.csveed.token.ParseStateMachine.determineState(int, EncounteredSymbol) calls equals on an enum instance |
CORRECTNESS |
ENMI_EQUALS_ON_ENUM |
253 |
Medium |
| To make log readable, log format ({} ({}): {} => {}) should contain non-sign character. |
BAD_PRACTICE |
SLF4J_SIGN_ONLY_FORMAT |
141 |
Medium |
org.csveed.token.ParseStateMachineTest
| Bug |
Category |
Details |
Line |
Priority |
| Method org.csveed.token.ParseStateMachineTest.windowsCrLf() excessively uses methods of another class |
STYLE |
CE_CLASS_ENVY |
49-59 |
Medium |
org.csveed.token.SymbolMapping
org.csveed.token.SymbolMappingTest
| Bug |
Category |
Details |
Line |
Priority |
| Method org.csveed.token.SymbolMappingTest.dissimilarEscapeAndQuote() excessively uses methods of another class |
STYLE |
CE_CLASS_ENVY |
74-81 |
Medium |
